Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: mention nodenv in README.md #2698

Merged
merged 1 commit into from Feb 18, 2021
Merged

docs: mention nodenv in README.md #2698

merged 1 commit into from Feb 18, 2021

Conversation

RA80533
Copy link
Contributor

@RA80533 RA80533 commented Feb 14, 2021

The PR adds nodenv to the list of available version managers in README.md.

The version manager in question has merit for being listed on the repository page due to its maturity and popularity (it has approx. 1.5k stars as of the time of posting).

@RA80533 RA80533 requested a review from a team as a code owner February 14, 2021 06:45
@ljharb
Copy link
Collaborator

ljharb commented Feb 14, 2021

This list can get long; should we have some criteria for inclusion in it? Popularity should perhaps be a factor (if so, 1.5k stars would put it near the bottom), but if not, how else do we filter?

@RA80533
Copy link
Contributor Author

RA80533 commented Feb 14, 2021

Having criteria would be reasonable.

@darcyclarke darcyclarke added Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release semver:patch semver patch level for changes labels Feb 17, 2021
Copy link
Contributor

@darcyclarke darcyclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RA80533 @ljharb ya, this is a weakly held list, more there for examples than anything & not fully vetted - I'd rather keep criteria loose vs. creating some kind of standard. Adding this makes sense.

@nlf nlf changed the base branch from latest to release/v7.5.5 February 18, 2021 20:37
@nlf nlf merged commit 38d87e7 into npm:release/v7.5.5 Feb 18, 2021
@nlf nlf mentioned this pull request Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release semver:patch semver patch level for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants