throw an error when trying to dedupe in global mode #2716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
Feb 17, 2021
darcyclarke
added
semver:patch
wraithgar
approved these changes
Feb 18, 2021
PR-URL: #2716 Credit: @nlf Close: #2716 Reviewed-by: @ljharb, @wraithgar
nlf
force-pushed
the
nlf/no-global-dedupe
branch
from
f1c6024
to
69e0c4e
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as described in #2620 it doesn't make much sense to globally dedupe, and clearly the wrong thing happens. let's just fail immediately instead of potentially breaking global packages.
References
Closes #2620