restore the prefix on output from npm version <inc>
#2718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraithgar
approved these changes
Feb 17, 2021
darcyclarke
added
semver:patch
PR-URL: #2718 Credit: @nlf Close: #2718 Reviewed-by: @wraithgar
nlf
force-pushed
the
nlf/restore-tag-prefix-on-version
branch
from
b4dcaa0
to
00afa31
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we used to do this in npm 6, and stopped in npm 7 unintentionally. this restores that behavior in a slightly more intelligent way.
by default the
--tag-version-prefixis'v'which means the result ofnpm version patchwould bev1.2.3matching the behavior in npm 6.the enhancement here is that if someone were to
npm version patch --tag-version-prefix=release/we would now outputrelease/1.2.3matching the tag we create.References
Closes #2653