Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(npm.output): make output go through npm.output #2795

Closed
wants to merge 7 commits into from

Conversation

wraithgar
Copy link
Member

All output that anything wants to make now goes through
npm.output(). This is an incremental change getting us
closer to where we want to be with testing.

This is built off of #2772 which needs to be merged before this is really reviewable.

@wraithgar wraithgar requested a review from a team as a code owner March 1, 2021 03:05
@darcyclarke darcyclarke added Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release labels Mar 1, 2021
ruyadorno added a commit to ruyadorno/cli that referenced this pull request Mar 1, 2021
This will allow for changing configs that are read by commands through
flatOptions.

Based of npm#2795, land that first.

Relates to: npm#2765
Relates to: npm/rfcs#117
@ruyadorno ruyadorno added the semver:patch semver patch level for changes label Mar 1, 2021
@darcyclarke darcyclarke removed the release: next These items should be addressed in the next release label Mar 4, 2021
Copy link
Contributor

@isaacs isaacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it. Will review again by grepping for output.js once #2772 lands ;)

Can we replace require('npmlog') with npm.log next?

@wraithgar
Copy link
Member Author

Can we replace require('npmlog') with npm.log next?

Yes this should be on our radar.

@darcyclarke darcyclarke added release: next These items should be addressed in the next release Needs Review labels Mar 6, 2021
All output that anything wants to make now goes through
`npm.output()`.  This is an incremental change getting us
closer to where we want to be with testing.

PR-URL: #2795
Credit: @wraithgar
Close: #2795
Reviewed-by: @ruyadorno, @isaacs
@wraithgar wraithgar closed this Mar 9, 2021
wraithgar added a commit that referenced this pull request Mar 9, 2021
All output that anything wants to make now goes through
`npm.output()`.  This is an incremental change getting us
closer to where we want to be with testing.

PR-URL: #2795
Credit: @wraithgar
Close: #2795
Reviewed-by: @ruyadorno, @isaacs
@wraithgar wraithgar mentioned this pull request Mar 9, 2021
This was referenced Mar 12, 2021
@wraithgar wraithgar deleted the gar/npm-output branch November 2, 2021 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release semver:patch semver patch level for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants