Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add completion for set-script #2925

Merged
merged 6 commits into from Mar 24, 2021
Merged

Add completion for set-script #2925

merged 6 commits into from Mar 24, 2021

Conversation

Yash-Singh1
Copy link
Contributor

This pull request implements tab completion for set-script. Most of the code from run-script.

@Yash-Singh1 Yash-Singh1 requested a review from a team as a code owner March 23, 2021 19:02
test/lib/set-script.js Outdated Show resolved Hide resolved
test/lib/set-script.js Outdated Show resolved Hide resolved
test/lib/set-script.js Outdated Show resolved Hide resolved
@Yash-Singh1 Yash-Singh1 changed the title Add completion for set-script Add completion for set-script Mar 23, 2021
Copy link
Collaborator

@ruyadorno ruyadorno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome 🙌 thanks!

@darcyclarke darcyclarke added Release 7.x work is associated with a specific npm 7 release semver:patch semver patch level for changes labels Mar 24, 2021
wraithgar and others added 6 commits March 24, 2021 10:26
`npm install` should not be affected by the `auditLevel` config, as the
results of audit do not change its exit status.

PR-URL: #2929
Credit: @wraithgar
Close: #2929
Reviewed-by: @ljharb, @ruyadorno
This is a valid level but wasn't configured to be allowed.

Also added this param to the usage output for `npm audit`

PR-URL: #2923
Credit: @wraithgar
Close: #2923
Reviewed-by: @ruyadorno
The logger was no longer in flatOptions, we pass it in explicitly now

PR-URL: #2944
Credit: @wraithgar
Close: #2944
Reviewed-by: @nlf
This was not being added to flatOptions, and things like
`npm-registry-fetch` are looking for it.

PR-URL: #2946
Credit: @wraithgar
Close: #2946
Reviewed-by: @nlf
@wraithgar wraithgar mentioned this pull request Mar 24, 2021
@wraithgar wraithgar merged commit c76f04a into npm:latest Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release 7.x work is associated with a specific npm 7 release semver:patch semver patch level for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants