fix(uninstall): use correct local prefix #2930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruyadorno
reviewed
Mar 24, 2021
|
Done 🙂 Thanks for spotting that! |
Corrects non-global prefix path by using this.npm.localPrefix. A location already used throughout the repository. Later, this will be taken from the unified config library. Signed-off-by: James Chen-Smith <jameschensmith@gmail.com> PR-URL: #2930 Credit: @jameschensmith Close: #2930 Reviewed-by: @ruyadorno
Merged
This was referenced Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A commit was made in v7.7.0, which removed references to
flatOptionsin favor of a more unified config. This caused a bug wherethis.npm.config.get('prefix')was using the global prefix.This request corrects the non-global prefix path by using
this.npm.localPrefix, a location already used throughout the repository (in the same file, inlib/prefix.js, etc.). Later, this value can be taken from the unified config library.References
Fixes #2927.