fix(exit-handler): always warn if not called #3561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraithgar
force-pushed
the
gar/always-exit-check
branch
from
c1e7fd4
to
031ea04
Compare
lukekarrys
approved these changes
Jul 22, 2021
If the exit handler wasn't called it is always a problem, even if there is no exit code. PR-URL: #3561 Credit: @wraithgar Close: #3561 Reviewed-by: @lukekarrys
wraithgar
force-pushed
the
gar/always-exit-check
branch
from
031ea04
to
009ad1e
Compare
Merged
This was referenced Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the exit handler wasn't called it is always a problem, even if there
is no exit code.