fix(node_modules): remove duplicated file #3591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is FINALLY only one file in here now. https://github.com/npm/cli/tree/gar/fix-case-sensitive-snafu/node_modules/socks/typings/common |
wraithgar
force-pushed
the
gar/fix-case-sensitive-snafu
branch
2 times, most recently
from
fdb28bd
to
f24fd6b
Compare
|
What had happened was: socks originally had this file as containing an upper case, as evidenced by the fact that it's still upper case in their git repo: https://github.com/JoshGlazebrook/socks/tree/master/typings/common It was published lower case in the tarball: And because git is case insensitive, but os/x isn't things went sideways. |
wraithgar
force-pushed
the
gar/fix-case-sensitive-snafu
branch
from
f24fd6b
to
f6efc44
Compare
|
Not sure why it thinks it's also changing the npm version to what it already is but it doesn't do that locally for me in git. |
isaacs
approved these changes
Jul 28, 2021
wraithgar
force-pushed
the
gar/fix-case-sensitive-snafu
branch
from
f6efc44
to
e197165
Compare
PR-URL: #3591 Credit: @wraithgar Close: #3591 Reviewed-by: @isaacs
wraithgar
force-pushed
the
gar/fix-case-sensitive-snafu
branch
from
e197165
to
72aa97c
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Case sensitivity on filesystems is tricky