fix(docs): update npm-publish access flag info #3630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Aug 8, 2021
darcyclarke
added
semver:patch
PR-URL: npm#3630 Credit: @austincho Close: npm#3630 Reviewed-by: @wraithgar
wraithgar
force-pushed
the
update-access-level-docs
branch
from
69d1dc0
to
d1812f1
Compare
|
Thanks for submitting this. docs are a very important part of the cli and improvements here are very much appreciated. |
Merged
|
Sorry about this, but when I accepted this I didn't realize it was in the auto-generated portion of these docs. We're gonna have to revert this and find a better place to put this. |
|
This is where we'd want to make the change cli/lib/utils/config/definitions.js Line 157 in 59b9851 |
wraithgar
pushed a commit
that referenced
this pull request
Aug 17, 2021
When we accidentally edit the auto-generated portions of the docs, this will catch the error and cause CI to fail. Later phase automated safety check that the early-stage human commenting in the last commit also addresses. Re: #3654 Re: #3630 PR-URL: #3655 Credit: @isaacs Close: #3655 Reviewed-by: @nlf
isaacs
pushed a commit
that referenced
this pull request
Aug 19, 2021
PR-URL: #3630 Credit: @austincho Close: #3630 Reviewed-by: @wraithgar EDIT(@isaacs): rebased and edited to put config documentation in the correct location.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only way to turn a public package that's been published to private (or vice versa) is to use
npm accessUsing the access flag on thenpm publishcommand after the initial publish, has no effect on the access level. The documentation on npm-publish should note these characteristics.References
Closes #1341