fix some flat options #3684
Merged
fix some flat options #3684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraithgar
reviewed
Aug 24, 2021
| @@ -121,7 +121,7 @@ class Config extends BaseCommand { | |||
| break | |||
| case 'list': | |||
| case 'ls': | |||
| await (this.npm.config.get('json') ? this.listJson() : this.list()) | |||
| await (this.npm.flatOptions.json ? this.listJson() : this.list()) | |||
There was a problem hiding this comment.
We really really really need to answer the "what do derived config values look like" question.
wraithgar
reviewed
Aug 26, 2021
wraithgar
approved these changes
Aug 26, 2021
darcyclarke
added
Release 7.x
This corrects two things, `--global` implies `--location=global` and `--package-lock-only` implies `--package-lock` It also introduces a new sandbox runner for testing purposes. it's not the prettiest thing i've ever written, but it seems to do the job pretty nicely and doesn't require keeping track of wild shenanigans everywhere. Fixes #2747 Fixes #3572 PR-URL: #3684 Credit: @nlf Close: #3684 Reviewed-by: @wraithgar
wraithgar
force-pushed
the
nlf/fix-some-flat-options
branch
from
585478a
to
4e52217
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects two things,
--globalimplies--location=globaland--package-lock-onlyimplies--package-lockit also introduces a new sandbox runner for testing purposes. it's not the prettiest thing i've ever written, but it seems to do the job pretty nicely and doesn't require keeping track of wild shenanigans everywhere.
References
Fixes #2747
Fixes #3572