Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(view): Show the correct publish date for versions selected by range #3739

Merged
merged 1 commit into from Sep 13, 2021

Conversation

andersk
Copy link
Contributor

@andersk andersk commented Sep 11, 2021

Before, npm view npm@^6 would incorrectly report “published over a year from now” for every entry. Now it reports the correct dates.

@wraithgar
Copy link
Member

Really good catch here, thank you. Just one note on making sure we're testing this new behavior, but other than that this is obviously the correct solution.

Copy link
Member

@wraithgar wraithgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting this

Before, `npm view npm@^6` would incorrectly report “published over a
year from now” for every entry.  Now it reports the correct dates.

PR-URL: npm#3739
Credit: @andersk
Close: npm#3739
Reviewed-by: @wraithgar
@wraithgar wraithgar changed the base branch from latest to release-next September 13, 2021 20:08
@wraithgar wraithgar merged commit 0320bd7 into npm:release-next Sep 13, 2021
@fritzy fritzy mentioned this pull request Sep 16, 2021
@andersk andersk deleted the view-date branch October 11, 2021 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants