Use configured registry when checking manifest for npm install #3760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraithgar
reviewed
Sep 15, 2021
|
Good catch! The |
|
Looks like linting failed. Max line length is 80, line is 81. We're upping that limit soon but for today you'll have to break it up. |
|
That worked! Thank you very much for submitting this PR. |
PR-URL: npm#3760 Credit: @yacoman89 Close: npm#3760 Reviewed-by: @wraithgar
wraithgar
force-pushed
the
npm-install-registry-mirror-fix
branch
from
271b75f
to
2def17a
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix resolves #3758.
The package pacote accepts options as it's second parameter for the manifest call and these options allow you to pass the desired registry to use. The npm config object already has this information, so it's just passed in now.