Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: restore exit code on "npm outdated" #3799

Closed
wants to merge 2 commits into from
Closed

fix: restore exit code on "npm outdated" #3799

wants to merge 2 commits into from

Conversation

gfyoung
Copy link
Contributor

@gfyoung gfyoung commented Sep 26, 2021

closes: #2556
ref: #1750

The xref'ed PR apparently dropped this behavior without any explanation.

  • Not sure if this is the right branch to PR against. Happy to switch to release-latest if appropriate.
  • Debated whether to write helper functions since exitCode and logs are somewhat related in terms of the expected results. I copy-pasted the exitCode check everywhere for the time being.

@gfyoung gfyoung requested a review from a team as a code owner September 26, 2021 03:28
@gfyoung
fix: restore exit code on "npm outdated"
c9cb522 
closes: npm#2556
xref: npm#1750

The xref'ed PR apparently dropped this behavior
without any explanation.
@gfyoung gfyoung changed the title (fix) restore exit code on "npm outdated" fix: restore exit code on "npm outdated" Sep 26, 2021
@gfyoung gfyoung mentioned this pull request Sep 26, 2021
Closed
@wraithgar wraithgar changed the base branch from latest to release-next September 27, 2021 13:52
@wraithgar
Copy link
Member

Smoke test will have to be fixed for this. smoke-tests/index.js line 175. You can copy the exit code check from the npm (no args) test on line 98

wraithgar
wraithgar reviewed Sep 27, 2021
View reviewed changes
lib/outdated.js Outdated Show resolved Hide resolved
@wraithgar wraithgar self-assigned this Sep 27, 2021
@gfyoung
Feedback updates
41cc10c 
* More compact exitCode check
* Update smoke-test to check exit code
@gfyoung
Copy link
Contributor Author

gfyoung commented Sep 27, 2021

@wraithgar: I've pushed a new commit to address the feedback. Smoke tests should be passing now.

wraithgar pushed a commit that referenced this pull request Sep 27, 2021
@gfyoung @wraithgar
fix: restore exit code on "npm outdated"
075fe50 
closes: #2556
xref: #1750

The xref'ed PR apparently dropped this behavior
without any explanation.

PR-URL: #3799
Credit: @gfyoung
Close: #3799
Reviewed-by: @wraithgar
@wraithgar
Copy link
Member

Not sure why this PR isn't showing as merged. It's in release-next 075fe50

@wraithgar wraithgar closed this Sep 27, 2021
@wraithgar
Copy link
Member

This will go out w/ Thursday's release. Thank you for submitting this fix!

@gfyoung gfyoung deleted the npm-outdated-exit-code branch September 28, 2021 21:26
This was referenced Sep 30, 2021
Closed
Merged
@npm-robot npm-robot mentioned this pull request Oct 4, 2021
Closed
This was referenced Oct 7, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wraithgar wraithgar wraithgar approved these changes

Assignees

@wraithgar wraithgar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] npm outdated no longer exits with code 1 if outdated
2 participants
@gfyoung @wraithgar