Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-scripts showing false critical vulnerabilities is ANNOYING #3930

Closed
1 task done
jap99 opened this issue Oct 21, 2021 · 2 comments
Closed
1 task done

react-scripts showing false critical vulnerabilities is ANNOYING #3930

jap99 opened this issue Oct 21, 2021 · 2 comments
Labels
Bug thing that needs fixing Needs Triage needs review for next steps Release 8.x work is associated with a specific npm 8 release

Comments

@jap99
Copy link

jap99 commented Oct 21, 2021

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

'npm audit' results in 10's, 100's of vulnerabilities, many / most being listed as critical.

Even though these false positive vulnerabilities are simply false positives, they're not only extremely annoying, but they will make it too difficult to identify anytime there is a real attack against the build toolchain because it will be hidden / buried in w/ all the false positives.

Please fix this ASAP.

Expected Behavior

Stop showing false positives; start with react-scripts.

Steps To Reproduce

Open multiple different react projects.
Each react project should have different versions of react, node, & other popular npm packages.
Do 'npm audit' & you'll see the issues.

Thank you.

Environment

No response

@jap99 jap99 added Bug thing that needs fixing Needs Triage needs review for next steps Release 8.x work is associated with a specific npm 8 release labels Oct 21, 2021
@lil5
Copy link

lil5 commented Oct 22, 2021

This "bug" is a symptom of a larger problem.

Some developers are of the opinion that because their package only runs on a developer's machine certain vulnerabilities would not effect their package (ddos).
Others have started bundling the vulnerable packages inside their package sidelining npm's audit system.

Hiding all 💯 vulnerabilities for those packages IMO will not help, as it gives a false sense of security.

I propose altering npm's deprecation system to be able to specify if the vulnerability will affect non-live environments.

@fritzy
Copy link
Contributor

fritzy commented Oct 26, 2021

This is being addressed and discussed as an RFC. Feel free to join the conversation. npm/rfcs#422

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug thing that needs fixing Needs Triage needs review for next steps Release 8.x work is associated with a specific npm 8 release
Projects
None yet
Development

No branches or pull requests

3 participants