fix(install): command completion with single match #4023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraithgar
force-pushed
the
gar/install-tests
branch
from
a6c542f
to
f445e0d
Compare
wraithgar
changed the title
|
Related to #4020? |
|
Nope that'd be a different issue, each command has its own completions function |
wraithgar
force-pushed
the
gar/install-tests
branch
5 times, most recently
from
3ecc7bd
to
d49addc
Compare
wraithgar
added
Release 8.x
lukekarrys
approved these changes
Nov 10, 2021
During a refactoring of the tests a bug was found in the install command completion that would return nothing if there was a valid match, this fixes that bug and also makes the tests actually test things. PR-URL: #4023 Credit: @wraithgar Close: #4023 Reviewed-by: @lukekarrys
wraithgar
force-pushed
the
gar/install-tests
branch
from
d49addc
to
b789491
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During a refactoring of the tests a bug was found in the install command
completion that would return nothing if there was a valid match, this
fixes that bug and also makes the tests actually test things.