Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: npm pack filename on scoped packages #5894

Merged

Conversation

HenryNguyen5
Copy link
Contributor

@HenryNguyen5 HenryNguyen5 commented Nov 24, 2022

When running npm pack on a scoped package, the file name would be incorrect, since the @ character should be removed, and the / character be replaced with a - character

References

Fixes #3405

When running `npm pack` on a scoped package, the file name would
be incorrect, since the `@` character should be removed, and the
`/` character be replaced with a `-` character
@HenryNguyen5 HenryNguyen5 requested a review from a team as a code owner November 24, 2022 18:57
@lukekarrys
Copy link
Member

Thank you @HenryNguyen5!

@fritzy fritzy merged commit ffbdea2 into npm:latest Nov 30, 2022
@github-actions github-actions bot mentioned this pull request Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] npm pack incorrect filename for scoped package
3 participants