Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] file: dependency is locked without package name when install is run for the 1st time #6430

Open
2 tasks done
mvorisek opened this issue May 7, 2023 · 3 comments · May be fixed by #7228
Open
2 tasks done

[BUG] file: dependency is locked without package name when install is run for the 1st time #6430

mvorisek opened this issue May 7, 2023 · 3 comments · May be fixed by #7228
Labels
Bug thing that needs fixing Needs Triage needs review for next steps Release 9.x work is associated with a specific npm 9 release

Comments

@mvorisek
Copy link

mvorisek commented May 7, 2023

Is there an existing issue for this?

  • I have searched the existing issues

This issue exists in the latest npm version

  • I am using the latest npm

Current Behavior

Please run the repro steps below. Currently when a file: dependency is required, it is added to the lock file without a name when the npm install is run for the 1st time. Even if there is no dependency change, when the npm install is rerun, the lock file is changed.

Expected Behavior

no lock file change

Steps To Reproduce

  1. git clone https://github.com/atk4/ui.git
  2. cd js
  3. rm package-lock.json
  4. npm i --package-lock-only
  5. cp package-lock.json package-lock2.json
  6. npm i --package-lock-only
  7. notice packages -> .eslint -> name key is added to the lock file (diff package-lock2.json package-lock.json)

image

Environment

  • npm: 9.6.4
  • Node.js: v19.8.1
  • OS Name: Windows 10 x64
@mvorisek mvorisek added Bug thing that needs fixing Needs Triage needs review for next steps Release 9.x work is associated with a specific npm 9 release labels May 7, 2023
@cascornelissen cascornelissen mentioned this issue Oct 3, 2023
Open
2 tasks
@mvorisek
Copy link
Author

mvorisek commented Oct 8, 2023

Can someone, please, look into this lock file instability issue?

@mvorisek
Copy link
Author

mvorisek commented Feb 1, 2024

Hi all, this issue is still present, can someone please confirm/reproduce it and fix it? Thank you in advance!

sonallux added a commit to sonallux/npm that referenced this issue Feb 18, 2024
@sonallux
chore: add reproduction test case for npm#6430
880c46d
@sonallux
Copy link

sonallux commented Feb 18, 2024 •
edited

I am also experiencing this issue and have looked into it a bit. The issue is only present when the folder name of the file: dependency is different from the package name.

I have created a reproduction test for this issue in this branch: https://github.com/sonallux/npm/tree/chore/6430-add-reproduction-test-case and opened PR #7228

sonallux added a commit to sonallux/npm that referenced this issue Feb 18, 2024
@sonallux
chore: add reproduction test case for npm#6430
737507b
@sonallux sonallux linked a pull request Feb 18, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug thing that needs fixing Needs Triage needs review for next steps Release 9.x work is associated with a specific npm 9 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: file dependency is locked without name sonallux/npm
2 participants
@mvorisek @sonallux