feat: create exit handler class #7442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukekarrys
force-pushed
the
lk/exit-handler-class-2
branch
10 times, most recently
from
8df95d2
to
9770c40
Compare
lukekarrys
force-pushed
the
lk/exit-handler-class-2
branch
from
9770c40
to
fcb1c26
Compare
lukekarrys
force-pushed
the
lk/exit-handler-class-2
branch
from
fcb1c26
to
3183eee
Compare
wraithgar
reviewed
May 6, 2024
| @@ -66,7 +66,6 @@ npm error | |||
| npm error aliases: clean-install, ic, install-clean, isntall-clean | |||
| npm error | |||
| npm error Run "npm help ci" for more info | |||
There was a problem hiding this comment.
this newline is present in most other situations where the complete log message is displayed.
There was a problem hiding this comment.
Testing locally this newline is now gone altogether in those other situations. Consistency is the thing here so we're good.
There was a problem hiding this comment.
Yes, glad you noticed. I couldn't find the true historical reason for this, but in refactoring I'm not confident we always display at least something to the user in all cases (even weird ones like npm is never set and then we error). But since this is truly just a display oriented newline, I wanted to remove it.
wraithgar
approved these changes
May 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
exit-handler.jsto be a class so that it can more easily track its internal state. It uses this state to now fully distinguish between 3 states: npm never being set, npm not loaded, and exit handler never called. There are some new error messages shown via console.error if we know we are in an unexpected state.This also continues the refactoring started in #7415 to separate concerns between
npmandCLI. Identifying the error message and logging it have been move tonpmbut catching that error and setting theprocess.exitCodeare still handled inexit-handler.jsandcli/entry.js.It also moves
command.cmdExectonpmsince it never called from within anycommandinstance. This letsnpmonly ever callcommand.execorcommand.workspaceExecnow.