Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-xmas-underline #179

Closed
wants to merge 1 commit into from
Closed

fix-xmas-underline #179

wants to merge 1 commit into from

Conversation

raywu0123
Copy link
Contributor

The previous code forgets to reset the double-underline setting so the xmas tree looks like this:
original-tree

with this patch, it looks more normal like this:

new-tree

@raywu0123 raywu0123 requested a review from a team as a code owner March 22, 2019 17:46
@isaacs isaacs added the semver:patch semver patch level for changes label Jun 26, 2019
@isaacs
Copy link
Contributor

isaacs commented Jul 2, 2019

This will be in 6.10.1. Thanks!

isaacs pushed a commit that referenced this pull request Jul 2, 2019
Credit: @raywu0123
PR-URL: #179
Close: #179
Reviewed-by: @isaacs
@isaacs isaacs mentioned this pull request Jul 2, 2019
@isaacs isaacs closed this in 172f9ac Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch semver patch level for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants