Fix figgyPudding error in npm token
#259
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that a couple of lines were missed when token.js was [changed to use figgyPudding](4cf850d#diff-398ed3b014436a5204583323ea29320b), which [causes an error](https://npm.community/t/npm-token-err-figgypudding-options-cannot-be-modified-use-concat-instead/10288) when trying to run that command in certain circumstances. This patch fixes that error. Tested locally by applying the patch to npm 6.11.3.
isaacs
reviewed
Sep 30, 2019
| } | ||
| if (conf.otp) conf.auth.otp = conf.otp | ||
| if (conf.otp) { |
There was a problem hiding this comment.
This second bit is actually not what you want. It means that npm token <whatever> --otp=123456 will throw away the auth.
Since we've already set auth to an object, we can modify that object, because it's not a key on the figgy pudding container.
I'll land this, but without that part, just posting this comment for posterity :)
Merged
This was referenced Oct 26, 2019
This was referenced Nov 5, 2019
This was referenced Nov 14, 2019
This was referenced Nov 25, 2019
This was referenced Dec 5, 2019
This was referenced Dec 18, 2019
This was referenced Jan 17, 2020
This was referenced Feb 25, 2020
This was referenced Feb 11, 2024
This was referenced Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that a couple of lines were missed when token.js was changed to use figgyPudding, which causes an error when trying to run that command in certain circumstances. This patch fixes that error.
Tested locally by applying the patch to npm 6.11.3.