feat: prompt before opening web-login URL when performing login/adduser
#4960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jumoel
changed the title
jumoel
changed the title
login/adduser
wraithgar
reviewed
Jun 16, 2022
wraithgar
approved these changes
Jun 20, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We want the npm CLI to prompt and wait before opening a URL.
The flow should be dependent on the authorization result and should continue without user input if the authorization is completed.
What
EventEmitterlogin/adduserto use the new prompt when applicableThe new
openerPromiseAPI is backwards compatible with the old one (it only adds new parameters), so it will work even without the changes fromnpm-profile.Without the changes from
npm-profile, the user will always have to pressEnterto continue the flow.References