Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable progress bar on publish #5172

Merged
merged 1 commit into from Jul 20, 2022
Merged

fix: disable progress bar on publish #5172

merged 1 commit into from Jul 20, 2022

Conversation

wraithgar
Copy link
Member

It is not supposed to be there, in that it doesn't get any updates and
gets in the way of logging messages. We already log the server we are
publishing to in the notice headers so the one http log message that
we get during publish isn't needed on stdout.

It is not supposed to be there, in that it doesn't get any updates and
gets in the way of logging messages.  We already log the server we are
publishing to in the `notice` headers so the one `http` log message that
we get during publish isn't needed on stdout.
@wraithgar wraithgar requested a review from a team as a code owner July 14, 2022 16:18
Copy link
Contributor

@nlf nlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes perfect sense to me

@npm-cli-bot
Copy link
Collaborator

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 35.671 ±0.50 15.105 ±0.14 13.478 ±0.13 15.685 ±0.60 2.438 ±0.02 2.410 ±0.04 1.978 ±0.00 9.384 ±0.04 1.982 ±0.00 2.934 ±0.05
#5172 40.217 ±7.83 15.467 ±0.31 13.710 ±0.19 16.346 ±1.05 2.571 ±0.13 2.467 ±0.02 2.004 ±0.01 9.724 ±0.19 2.011 ±0.00 3.242 ±0.31
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 25.041 ±0.11 11.546 ±0.08 10.259 ±0.05 10.852 ±0.01 2.303 ±0.06 2.226 ±0.01 2.058 ±0.01 6.943 ±0.03 1.911 ±0.03 2.671 ±0.00
#5172 27.804 ±0.23 11.824 ±0.01 10.590 ±0.03 11.326 ±0.11 2.260 ±0.02 2.264 ±0.01 2.086 ±0.01 7.040 ±0.05 1.937 ±0.02 2.748 ±0.05

Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@fritzy fritzy merged commit 9c590fa into latest Jul 20, 2022
@fritzy fritzy deleted the gar/publish-progress branch July 20, 2022 18:32
@fritzy fritzy mentioned this pull request Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants