Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gar/libnpmexec fixes #5244

Merged
merged 6 commits into from Aug 2, 2022
Merged

gar/libnpmexec fixes #5244

merged 6 commits into from Aug 2, 2022

Conversation

wraithgar
Copy link
Member

  • deps: add @npmcli/fs@2.1.1
  • deps: add semver@7.3.7
  • deps: @npmcli/run-script@4.2.0
  • fix: properly find locally/globally/npxCache packages
  • fix: use binPaths

@wraithgar wraithgar requested a review from a team as a code owner August 2, 2022 16:13
@wraithgar
Copy link
Member Author

wraithgar commented Aug 2, 2022 •
edited

Closes #3210

@wraithgar wraithgar marked this pull request as draft August 2, 2022 16:21
@wraithgar
Copy link
Member Author

Closes #5132
Closes #5018

@wraithgar
fix: properly find locally/globally/npxCache packages
055b843 
Lots of bugfixes here, we properly parse ranges and versions, and we
also now work with git repos and gists, and know when they are already
installed.
@wraithgar
fix: use binPaths
d6fa4cc 
This will allow for a locally installed package to differ from the one
requested on the command line, the one requested will now actually run.
@npm-cli-bot
Copy link
Collaborator

npm-cli-bot commented Aug 2, 2022 •
edited

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 50.170 ±6.82 25.444 ±0.45 30.092 ±10.22 26.949 ±1.26 4.119 ±0.09 3.941 ±0.04 3.170 ±0.03 16.395 ±0.02 3.135 ±0.03 4.610 ±0.02
#5244 47.323 ±0.94 26.005 ±0.17 33.275 ±12.24 26.515 ±0.68 3.853 ±0.02 3.907 ±0.04 3.253 ±0.04 16.631 ±0.00 3.319 ±0.06 4.755 ±0.08
app-medium clean lock-only cache-only cache-only
peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 33.038 ±2.01 18.815 ±0.12 17.371 ±0.07 18.415 ±0.86 3.570 ±0.04 3.569 ±0.07 3.132 ±0.03 11.650 ±0.04 3.079 ±0.02 4.055 ±0.06
#5244 34.271 ±0.53 19.371 ±0.05 17.494 ±0.01 18.128 ±0.26 3.582 ±0.00 3.597 ±0.02 3.252 ±0.05 11.865 ±0.34 3.090 ±0.06 4.228 ±0.09

@wraithgar
Copy link
Member Author

Closes #4204

@wraithgar
Copy link
Member Author

Closes #3058

@wraithgar wraithgar force-pushed the gar/libnpmexec-fixes branch 3 times, most recently from 885063e to 1d186fe Compare August 2, 2022 20:42
@wraithgar
fix: fix exec tests and clean up workspace-location-msg
6038528 
The workspace-location-msg file was being called improperly by `npm
init` and not even tested, and when digging in it probably shouldn't be
used at all from there. It's not always a workspace in this context.
@wraithgar wraithgar marked this pull request as ready for review August 2, 2022 20:51
@nlf nlf merged commit 3b30af2 into latest Aug 2, 2022
@nlf nlf deleted the gar/libnpmexec-fixes branch August 2, 2022 21:57
@nlf nlf mentioned this pull request Aug 3, 2022
Merged
@npm-cli-bot npm-cli-bot mentioned this pull request Aug 3, 2022
Merged
@jlarmstrongiv
Copy link

jlarmstrongiv commented Aug 5, 2022 •
edited

@wraithgar comment converted to #5269

@jlarmstrongiv jlarmstrongiv mentioned this pull request Aug 5, 2022
Closed
2 tasks
@sodatea sodatea mentioned this pull request Jul 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlf nlf nlf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wraithgar @npm-cli-bot @jlarmstrongiv @nlf