Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly find and run global scoped packages #5250

Merged
merged 1 commit into from Aug 3, 2022

Conversation

wraithgar
Copy link
Member

@wraithgar wraithgar commented Aug 3, 2022

Closes #4054

@wraithgar wraithgar requested a review from a team as a code owner August 3, 2022 14:57
@wraithgar wraithgar force-pushed the gar/libnpmexec-global-scoped branch from 6d63e62 to 418259f Compare August 3, 2022 15:11
@wraithgar
Copy link
Member Author

Screen Shot 2022-08-03 at 8 15 16 AM

@wraithgar wraithgar force-pushed the gar/libnpmexec-global-scoped branch from 418259f to 23a92ab Compare August 3, 2022 15:21
@npm-cli-bot
Copy link
Collaborator

npm-cli-bot commented Aug 3, 2022

found 1 benchmarks with statistically significant performance regressions

  • app-medium: clean
timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 35.828 ±0.35 16.683 ±0.31 15.355 ±0.44 17.584 ±0.62 2.768 ±0.17 2.634 ±0.01 2.204 ±0.09 10.474 ±0.02 2.146 ±0.00 3.926 ±1.10
#5250 38.052 ±1.55 16.737 ±0.07 15.151 ±0.03 17.312 ±0.07 2.702 ±0.04 2.672 ±0.01 2.197 ±0.01 10.564 ±0.00 2.177 ±0.01 3.209 ±0.07
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 26.963 ±0.20 12.843 ±0.16 11.297 ±0.10 12.863 ±1.21 2.443 ±0.04 2.419 ±0.00 2.187 ±0.00 7.642 ±0.06 2.038 ±0.00 2.779 ±0.01
#5250 30.325 ±0.43 12.777 ±0.00 11.238 ±0.04 12.092 ±0.12 2.449 ±0.01 2.448 ±0.01 2.204 ±0.01 7.751 ±0.03 2.083 ±0.00 2.825 ±0.02

@nlf nlf merged commit 19a8346 into latest Aug 3, 2022
@nlf nlf deleted the gar/libnpmexec-global-scoped branch August 3, 2022 15:36
@nlf nlf mentioned this pull request Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] npm exec does not use globally installed scoped packages
3 participants