Linting for #5225

[wraithgar]

This updates linting on all the repos except for docs that fail due to #5225.

Landing this (rebase and merge) will also land #5225. These should go together.

[wraithgar]

#5309 Should probably land first too because linting errors in docs are in files that will go away once that lands.

[lukekarrys]

I think this should go before #5309. I think the easiest way for that to happen and avoid conflicts is create a docs/.eslintrc.local.json files that turns off the one failure there with this config:

{ "rules": { "import/no-extraneous-dependencies": "off" } }

And then as part of #5309 I will remove that config.

[npm-cli-bot]

no statistically significant performance changes detected

timing results

app-large	clean	lock-only	cache-only	cache-only peer-deps	modules-only	no-lock	no-cache	no-modules	no-clean	no-clean audit
npm@8	36.560 ±0.96	15.962 ±0.01	14.240 ±0.04	17.376 ±1.79	2.524 ±0.01	2.526 ±0.02	2.057 ±0.01	9.868 ±0.04	2.063 ±0.01	2.970 ±0.01
#5323	39.700 ±3.60	15.870 ±0.05	14.188 ±0.05	16.162 ±0.07	2.497 ±0.04	2.501 ±0.01	2.050 ±0.00	9.767 ±0.03	2.057 ±0.02	3.230 ±0.32

app-medium	clean	lock-only	cache-only	cache-only peer-deps	modules-only	no-lock	no-cache	no-modules	no-clean	no-clean audit
npm@8	28.097 ±1.69	12.263 ±0.02	10.719 ±0.00	11.856 ±0.77	2.347 ±0.03	2.342 ±0.00	2.100 ±0.01	7.221 ±0.00	1.981 ±0.01	2.742 ±0.05
#5323	27.660 ±0.55	12.130 ±0.22	10.593 ±0.02	11.616 ±0.34	2.359 ±0.04	2.312 ±0.00	2.120 ±0.07	7.231 ±0.02	1.958 ±0.01	3.021 ±0.50