Fix issue with sub folder local references

[jtwebman]

This is using @iarna PR #40 adding tests and rebasing on latest.

fixes: https://npm.community/t/issue-npm-install-with-local-packages-and-symlinks-enoent/518

• Repro test from https://npm.community/t/npm-install-for-package-with-local-dependency-fails/754/10

[jtwebman]

@zkat or any one else that has write access to this repo can you re-run the failed test? Looks like Travis-CI had issues nothing to do with the code.

[zkat]

I'm gonna want to review this with @iarna before merging.

[aukevanleeuwen]

I'm not really in favor of +1 like comments, but in this case: I'm really really looking forward to this fix since it seems to match my case exactly.

--
Also wanted to link npm/npm#13528 because that's where my quest started out some time ago. I know the repo is archived, but maybe that issue still gets a reference automatically.

[zoellner]

To anyone who ends up here from npm/npm#13528 and if you've run across this problem just recently: - this error recently showed up a lot because of a pulled package with a vulnerability. See dominictarr/event-stream#116 for details.

[stevebaxter]

Is there a workaround for this? This has completely screwed our project right now.

[jtwebman]

@iarna Could we get a review on this so @zkat can merge this.

[sahellebusch]

I'm going to echo others here since this isn't budging. This is a breaking change that is problematic to many developers. Yes, a major version, but just as JS is always backwards compatible, I would imagine the package manager would be as well. I know there are arguments for how this should be done, but for the time being this should be merged to fix the immediate needs of those who are facing the same challenges and cannot upgrade to the latest npm version.

[baptistemarchand]

@zkat @iarna are there any issues blocking this from being merged?

It looks like it would solve issues for many users.

Thanks!

[Jmacek]

I would like to vote for this being merged soon please, this has been an issue for my team as well.

Thanks

[zkat]

I'm gonna approve this -- tests look ok, and the code is from #40, which has been pending for a while now. Cheers!

[baptistemarchand]

Hello,
Will this change be included in the next release? (on February 6th)
Thanks!

[jbinard]

Please add this fix in the next release, this is a real issue for my team.

Thanks!