Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cross-drive linking #21

Open
jddxf opened this issue Apr 3, 2017 · 6 comments
Open

Support cross-drive linking #21

jddxf opened this issue Apr 3, 2017 · 6 comments

Comments

@jddxf
Copy link

jddxf commented Apr 3, 2017

Currently we cannot link a file to a different drive. E.g. cmdShim('C:\\a.js', 'D:\\a', () => {}) would generate files containg "$basedir/C:/a.js" or "%~dp0\C:\a.js", which are broken due to the unresolvable paths.

In this case, we can use an absolute path instead, i.e. using "C:/a.js" rather than "$basedir/C:/a.js".

If this is a valid use case, I'd like to work on it.

@stacy-rendall
Copy link

Please do - I am experiencing this issue also

1 similar comment
@yasz
Copy link

yasz commented Jan 3, 2019

Please do - I am experiencing this issue also

@cspotcode
Copy link

Users of npm.im/pwsh reported this bug recently: cspotcode/npm-pwsh#18

@isaacs
Copy link
Contributor

isaacs commented Aug 15, 2019

Patch welcome for this. Or I'll get to it in a few weeks, probably.

@npm npm deleted a comment from DanielRuf Aug 15, 2019
@npm npm deleted a comment from DanielRuf Aug 15, 2019
@npm npm deleted a comment from DanielRuf Aug 15, 2019
@npm npm deleted a comment from cspotcode Aug 15, 2019
@isaacs

This comment has been minimized.

@isaacs
Copy link
Contributor

isaacs commented Aug 16, 2019

Just leaving a note here that it's likely that this will be a breaking change if implemented. (That's not to say it shouldn't be implemented, but just that it'll require a semver major bump, and an update to read-cmd-shim, since the path will no longer contain %~dp0 or %dp0%.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants