Powershell - Windows - Fix resolving commands that do not have an exe file #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
force-pushed
the
powershell_support_no_exe
branch
from
4e18b58
to
e8869ef
Compare
dsherret
force-pushed
the
powershell_support_no_exe
branch
from
e8869ef
to
d7c390b
Compare
dsherret
commented
Feb 17, 2021
| @@ -50,7 +50,7 @@ test('fails if from doesnt exist', t => { | |||
| test('fails if mkdir fails', t => { | |||
| var from = path.resolve(fixtures, 'from.env') | |||
| var to = path.resolve(fixtures, 'from.env/a/b/c') | |||
| return t.rejects(cmdShim(from, to), { code: /^(ENOTDIR|EEXIST)$/ }) | |||
| return t.rejects(cmdShim(from, to), { code: /^(ENOTDIR|EEXIST|ENOENT)$/ }) | |||
There was a problem hiding this comment.
I needed to add this to get the tests to pass on Windows. Let me know if I should revert this.
|
Anything I can do to help move this forward? |
|
I think that the problem is with the node version so kindly check whether your project is adopatable to which version of node and process it further, hence it worked for me if its wrong pls leave comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, the current powershell implementation assumes the command will resolve to a file with an
.exeextension, but the file may be a.bat,.ps1,.cmd, or other type of executable..exeextension and prefers that.nodefile and it prefers executingnode.exewhen writingnode. Also, why are Linux and Windows builds in the same directory (see what the comment said)? Perhaps this is too much of a breaking change or I am mistaken here, so let me know.References
Closes #51