Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support mode flag by verbatimSymlinks polyfill #74

Open
1 task done
tetsuharuohzeki opened this issue May 4, 2023 · 1 comment
Open
1 task done

feat: Support mode flag by verbatimSymlinks polyfill #74

tetsuharuohzeki opened this issue May 4, 2023 · 1 comment
Labels
Needs Triage needs an initial review

Comments

@tetsuharuohzeki
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Node.js v17.6.0 (also v16.15.0) add the support verbatimSymlinks option to fsPromises.cp().

But the current polyfill for cp() implementation has not supported it yet.

fs/lib/cp/index.js

Line 11 in b788931

copy: ['dereference', 'errorOnExist', 'filter', 'force', 'preserveTimestamps', 'recursive'],

Expected Behavior

cp() polyfill should support verbatimSymlinks option

Steps To Reproduce

I wrote in the above.

Environment

I wrote in the above.
@tetsuharuohzeki tetsuharuohzeki added the Needs Triage needs an initial review label May 4, 2023
@tetsuharuohzeki
Copy link
Author

The PR for Node.js is nodejs/node#41819

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs Triage needs an initial review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tetsuharuohzeki