Skip to content
This repository has been archived by the owner on May 4, 2024. It is now read-only.

every time I use it, I expect show to pulse too #41

Open
iarna opened this issue Mar 24, 2016 · 1 comment
Open

every time I use it, I expect show to pulse too #41

iarna opened this issue Mar 24, 2016 · 1 comment

Comments

@iarna
Copy link
Contributor

iarna commented Mar 24, 2016

Soo, any time I use it outside npmlog (which pulses on loglines only), I'm inevitably confused why just calling gauge.show on changes doesn't make the spinner spin.

I'm now of the opinion that gauge.show should increment the spinner just the way pulse does. This would make the two commands essentially identical, just having different short-cut type arguments– show being section and completed, and pulse be subsection. It might be time to just eliminate pulse entirely.

@lafiosca
Copy link

Just started using gauge for the first time -- excellent work, btw -- and I agree with this. I wrote a short test app and was surprised the spinner didn't change, then immediately tried adding the pulse call to each show call and saw the results I wanted.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants