fix: fail properly if uid-number raises an error

Author: isaacs

index.js

@@ -265,6 +265,12 @@ function runCmd (note, cmd, pkg, env, stage, wd, opts, cb) {
     runCmd_(cmd, pkg, env, wd, opts, stage, unsafe, 0, 0, cb)
   } else {
     uidNumber(user, group, function (er, uid, gid) {
+      if (er) {
+        er.code = 'EUIDLOOKUP'
+        opts.log.resume()
+        process.nextTick(dequeue)
+        return cb(er)
+      }
       runCmd_(cmd, pkg, env, wd, opts, stage, unsafe, uid, gid, cb)
     })
   }

test/fixtures/count-to-10-working-postinstall/package.json

@@ -0,0 +1,7 @@
+{
+  "name": "count-to-10-working-postinstall",
+  "version": "1.0.0",
+  "scripts": {
+    "postinstall": "node postinstall.js"
+  }
+}

test/fixtures/count-to-10-working-postinstall/postinstall.js

@@ -0,0 +1,5 @@
+'use strict'
+
+console.log('line 1')
+console.log('line 2')
+console.error('some error')

test/index.js

@@ -26,7 +26,7 @@ test('makeEnv', function (t) {
   const env = lifecycle.makeEnv(pkg, {
     config,
     nodeOptions: '--inspect-brk --abort-on-uncaught-exception'
-  }, null, process.env)
+  }, null, Object.assign({}, process.env))
 
   t.equal('myPackage', env.npm_package_name, 'package data is included')
   t.equal('Mike Sherov', env.npm_package_contributors_0_name, 'nested package data is included')
@@ -186,3 +186,32 @@ test("reports child's output", function (t) {
     })
     .catch(t.end)
 })
+
+test('fails when given an invalid user id', {
+  skip: process.platform === 'win32' ? 'windows always in unsafe mode' : false
+}, function (t) {
+  const fixture = path.join(__dirname, 'fixtures', 'count-to-10-working-postinstall')
+  const dir = fixture
+
+  const pkg = require(path.join(fixture, 'package.json'))
+  t.rejects(lifecycle(pkg, 'postinstall', fixture, {
+    stdio: 'pipe',
+    log: {
+      level: 'silent',
+      info: noop,
+      warn: noop,
+      silly: noop,
+      verbose: noop,
+      pause: noop,
+      resume: noop,
+      clearProgress: noop,
+      showProgress: noop
+    },
+    dir,
+    user: 'this-user-name-does-not-exist-at-least-i-sure-hope-not',
+    group: 'maybe-there-are-a-bunch-of-us-who-do-not-exist',
+    unsafePerm: false,
+    config: {}
+  }), { code: 'EUIDLOOKUP' })
+  t.end()
+})