Skip to content
This repository was archived by the owner on Aug 11, 2021. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: npm/npm-lifecycle
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.1.1
Choose a base ref
...
head repository: npm/npm-lifecycle
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.1.2
Choose a head ref
  • 2 commits
  • 4 files changed
  • 1 contributor

Commits on Jul 22, 2019

  1. fix: do not exclude /path/ from process.env copying 

    Previously, we were forcing only the "canonical" env.Path on windows or
env.PATH on Unix.  However, msysgit bash uses env.PATH instead of
env.Path.

The result was that either the system path wasn't loaded (so binaries
like 'npm' couldn't be found in windows bash) or the local node_modules
paths weren't loaded (in windows cmd.exe, depending on environment
variable key order).  And, since they weren't being copied to the
object, the mergePath logic had no effect.
    @isaacs
    isaacs committed Jul 22, 2019

    Unverified

    This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
    Learn about vigilant mode
    Copy the full SHA
    53e6318 View commit details

  2. chore(release): 3.1.2

    @isaacs
    isaacs committed Jul 22, 2019

    Verified

    This commit was signed with the committer’s verified signature.
    isaacs isaacs
    GPG key ID: B0C66F6FB6EA3BB6
    Verified
    Learn about vigilant mode
    Copy the full SHA
    355ad53 View commit details
Showing with 13 additions and 3 deletions.
  1. +10 −0 CHANGELOG.md
  2. +1 −1 index.js
  3. +1 −1 package-lock.json
  4. +1 −1 package.json
10 changes: 10 additions & 0 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -2,6 +2,16 @@

All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.

<a name="3.1.2"></a>
## [3.1.2](https://github.com/npm/lifecycle/compare/v3.1.1...v3.1.2) (2019-07-22)


### Bug Fixes

* do not exclude /path/ from process.env copying ([53e6318](https://github.com/npm/lifecycle/commit/53e6318))



<a name="3.1.0"></a>
# [3.1.0](https://github.com/npm/lifecycle/compare/v3.0.0...v3.1.0) (2019-07-17)

2 changes: 1 addition & 1 deletion index.js
View file
Original file line number Diff line number Diff line change
@@ -388,7 +388,7 @@ function makeEnv (data, opts, prefix, env) {
if (!env) {
env = {}
for (var i in process.env) {
if (!i.match(/^npm_/) && (!i.match(/^PATH$/i) || i === PATH)) {
if (!i.match(/^npm_/)) {
env[i] = process.env[i]
}
}
2 changes: 1 addition & 1 deletion package-lock.json
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "npm-lifecycle",
"version": "3.1.1",
"version": "3.1.2",
"description": "JavaScript package lifecycle hook runner",
"main": "index.js",
"scripts": {