fix(lru): use map.delete() directly (#713)

negezor · lukekarrys · web-flow · commit 6466ba9b5402 · 2024-05-08T19:02:38.000-07:00
The default implementation already returns boolean if the value has been deleted. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Map/delete#return_value It's also faster since we don't double check the hashmap for a value. --------- Co-authored-by: Luke Karrys <luke@lukekarrys.com>
diff --git a/internal/lrucache.js b/internal/lrucache.js
@@ -17,12 +17,7 @@ class LRUCache {
   }
 
   delete (key) {
-    if (this.map.has(key)) {
-      this.map.delete(key)
-      return true
-    } else {
-      return false
-    }
+    return this.map.delete(key)
   }
 
   set (key, value) {

Original file line number	Diff line number	Diff line change
`@@ -17,12 +17,7 @@ class LRUCache {`
`17`	`17`	`}`
`18`	`18`
`19`	`19`	`delete (key) {`
`20`		`- if (this.map.has(key)) {`
`21`		`- this.map.delete(key)`
`22`		`- return true`
`23`		`- } else {`
`24`		`- return false`
`25`		`- }`
	`20`	`+ return this.map.delete(key)`
`26`	`21`	`}`
`27`	`22`
`28`	`23`	`set (key, value) {`