Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Numerical Versions After X-Ranges Are Ignored #511

Open
1 task done
WalkerCodeRanger opened this issue Dec 26, 2022 · 1 comment
Open
1 task done

[BUG] Numerical Versions After X-Ranges Are Ignored #511

WalkerCodeRanger opened this issue Dec 26, 2022 · 1 comment
Labels
Bug thing that needs fixing Needs Triage needs an initial review

Comments

@WalkerCodeRanger
Copy link

WalkerCodeRanger commented Dec 26, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

A version range like 1.x.5 is valid and treated as equivalent to 1.x.x.

Expected Behavior

1.x.5 should either be invalid or match only versions like 1.0.5 and 1.10.5 but not versions like 1.0.0 or 1.2.3.

Steps To Reproduce

As I am not a Node developer but rather a maintainer of a semver package for C# that needs to support npm style version ranges, I am using https://semver.npmjs.com/ to test. Simply put the listed versions into it.

@WalkerCodeRanger WalkerCodeRanger added Bug thing that needs fixing Needs Triage needs an initial review labels Dec 26, 2022
@ljharb
Copy link

ljharb commented Dec 26, 2022

I think it should just be invalid. a non-x specifier after an x specifier makes no sense at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug thing that needs fixing Needs Triage needs an initial review
Projects
None yet
Development

No branches or pull requests

2 participants