Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QUESTION] Range class represents a range-set? #669

Open
1 task done
timreichen opened this issue Dec 15, 2023 · 1 comment
Open
1 task done

[QUESTION] Range class represents a range-set? #669

timreichen opened this issue Dec 15, 2023 · 1 comment
Labels
Bug thing that needs fixing Needs Triage needs an initial review

Comments

@timreichen
Copy link

timreichen commented Dec 15, 2023 •
edited

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

When looking at the Range class implementation, the parse() splits the input by || and format() joins it with ||.
According to the bnf, this is a range-set.
This is confusing as the Range class has a property called set. Why is it named Range and not RangeSet?

Expected Behavior

No response

Steps To Reproduce

No response

Environment

No response
@timreichen timreichen added Bug thing that needs fixing Needs Triage needs an initial review labels Dec 15, 2023
@timreichen timreichen mentioned this issue Dec 15, 2023
Closed
@timreichen timreichen changed the title [QUESTION] Range class is actually a range-set? [QUESTION] Range class represents a range-set? Dec 15, 2023
@mbtools
Copy link
Contributor

mbtools commented Feb 1, 2024

Because over 10 years ago, @isaacs decided to call it Range and now a change would break the world 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug thing that needs fixing Needs Triage needs an initial review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timreichen @mbtools