Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUESTION] Does original code accept empty name and/or version string? #7

Open
myrne opened this issue Apr 8, 2013 · 0 comments
Open
Labels

Comments

@myrne
Copy link
Contributor

myrne commented Apr 8, 2013

Original code:

function validName (file, data) {
                if (!data.name) {
                                data.name = ""
                                return true
                }
// some more stuff
}

Perhaps in the whole npm flow, name and version are checked somewhere else as well. But as stand-alone module, I think it'd be better to throw here as well.

@darcyclarke darcyclarke changed the title Does original code accept empty name and/or version string? [QUESTION] Does original code accept empty name and/or version string? Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants