Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set 'npm-auth-type' header depending on config option #123

Merged
merged 3 commits into from
Jun 25, 2022

Conversation

jumoel
Copy link
Contributor

@jumoel jumoel commented Jun 22, 2022

What

Set the npm-auth-type header to the value of the --auth-type command line parameter.

Why

Allows the registry to know if the npm client is capable of handling new web based flows for commands that require extra verification steps.

References

@jumoel jumoel requested a review from a team as a code owner June 22, 2022 06:56
@wraithgar
Copy link
Member

We should have a test to make sure this gets set

@jumoel
Copy link
Contributor Author

jumoel commented Jun 23, 2022

@wraithgar:

We should have a test to make sure this gets set

Done: 740af28

test/index.js Outdated Show resolved Hide resolved
lib/index.js Outdated Show resolved Hide resolved
@jumoel jumoel changed the title feat: set 'npm-use-webauthn' header depending on config option feat: set 'npm-auth-type' header depending on config option Jun 24, 2022
Copy link

@darcyclarke darcyclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants