Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be smarter about when to use git+https and when to use git+ssh for hosted git repos #65

Open
isaacs opened this issue Feb 17, 2021 · 3 comments
Assignees

Comments

@isaacs
Copy link
Contributor

isaacs commented Feb 17, 2021

Tracking issue: npm/cli#2610 (comment)

@isaacs
Copy link
Contributor Author

isaacs commented Mar 8, 2021

Plan: https://docs.google.com/spreadsheets/d/1C3aOFtUeanUoFOJQFRGqfL5j6jRiIBYBKEMCacoom0w/edit?usp=sharing

  • fail CDN fast, no exponential backoff retrying, fixes GitLab
  • save same sort of thing to package-lock and package.json (but with sha in package-lock, with ref in package.json)
  • tell git+ssh to accept new keys, but fail on changed keys
  • principle: CDN is suggested by git+https working for rev-list
  • don't try to clone over a strategy that failed rev-list (except as a final fallback)
  • priority: CDN as long as git+https hasn't failed yet. then what the user told us, unless we saw that fail on rev-list, in which case the other one, then whichever one we haven't tried yet
  • never send auth to CDN
  • track all CDN failures by user/project in pacote.Git (static/module-local list)
  • track all rev-list strategies by user/project in pacote.Git (static/module-local list)

Screen Shot 2021-03-08 at 12 59 47

@majidkhan12
Copy link

Please help me I also have the same problem.

@raineorshine
Copy link
Contributor

@majidkhan12 This isn't an appropriate comment for an open source repository. We're all waiting for this to be fixed, and I'm sure the developers have a lot of different priorities. Saying you also have the problem doesn't help anyone and spams all subscribers to the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants