Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(explain): Deprecate & warn for npm explain <path> #514

Closed
Tracked by #489
darcyclarke opened this issue May 16, 2022 · 4 comments
Closed
Tracked by #489

feat(explain): Deprecate & warn for npm explain <path> #514

darcyclarke opened this issue May 16, 2022 · 4 comments
Assignees

Comments

@darcyclarke
Copy link
Contributor

No description provided.

@darcyclarke darcyclarke mentioned this issue May 16, 2022
13 tasks
@darcyclarke darcyclarke changed the title feat: add deprecation warning for <code class="notranslate">npm explain <path>` feat: add deprecation warning for npm explain <path> May 16, 2022
@darcyclarke darcyclarke changed the title feat: add deprecation warning for npm explain <path> feat(explain): add deprecation warning for npm explain <path> May 16, 2022
@ljharb
Copy link

ljharb commented May 16, 2022

This is distinct from npm explain <specifier>, yes?

Why deprecate it?

@darcyclarke darcyclarke changed the title feat(explain): add deprecation warning for npm explain <path> feat(explain): Deprecate & warn for npm explain <path> Aug 22, 2022
@darcyclarke
Copy link
Contributor Author

@wraithgar I think you brought this up previously, can you add a quick summary?

@wraithgar
Copy link
Member

I have no memory of this one

@darcyclarke
Copy link
Contributor Author

@ljharb I think the confusion here was that a folder can be a valid package-spec. We're not removing the functionality here, we just update the documentation to clearly state npm explain supports a package-spec.

I'm going to close this since the work actually was completed by @wraithgar here: npm/cli#5048

Thanks for flagging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants