We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fsync
I'm writing 6,700 files. If I pass fsync: false to the options, it takes 9 seconds. If I don't, it defaults to true, and it takes 152 seconds (!).
fsync: false
true
From the docs I see this:
If the fsync option is false, writeFile will skip the final fsync call.
Could you explain how important this final fsync call is? I'm considering to disable it.
I wish to have it faster, or understand whether it's safe to cancel the fsync.
try to write lots of files ( > 1000) to see the issue clearly.
The text was updated successfully, but these errors were encountered:
perf, fix writing files performance by disabling fsync (#7226)
6678690
Writing object files is 16 times faster with this change. See npm/write-file-atomic#155 for more info.
No branches or pull requests
Is there an existing issue for this?
Current Behavior
I'm writing 6,700 files.
If I pass
fsync: false
to the options, it takes 9 seconds.If I don't, it defaults to
true
, and it takes 152 seconds (!).From the docs I see this:
Could you explain how important this final fsync call is? I'm considering to disable it.
Expected Behavior
I wish to have it faster, or understand whether it's safe to cancel the fsync.
Steps To Reproduce
try to write lots of files ( > 1000) to see the issue clearly.
Environment
The text was updated successfully, but these errors were encountered: