Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSA: Upcoming large code updates in Core #159

Closed
nytamin opened this issue Jan 20, 2020 · 1 comment
Closed

PSA: Upcoming large code updates in Core #159

nytamin opened this issue Jan 20, 2020 · 1 comment
Labels
📢 PSA An announcement about upcoming changes

Comments

@nytamin
Copy link
Contributor

nytamin commented Jan 20, 2020

This is a PSA about a fairly large upcoming code-change that are planned for Core.

Code formatting
PR: #146
We will start using Prettier as code formatter for the project.

This will result in a lot of code that will be changed (formatted differently), which might affect how easy it is to make PR:s and commits from external repos.
It is therefore recommended that any contributions made by external contributors be presented at the latest 2020-02-10.
The Code formatting will be applied 2020-02-18, so expect to have to rebase any changes done after that.

Note: The formatting have not been applied yet, we're wrapping some things internally and hope to get around to it asap.

@nytamin nytamin changed the title PSA: Large code updates in Core PSA: Upcoming large code updates in Core Jan 20, 2020
@jstarpl jstarpl added the 📢 PSA An announcement about upcoming changes label Jan 21, 2020
@Julusian
Copy link
Member

#240

nytamin pushed a commit that referenced this issue Sep 19, 2022
chore: SOF-1072 Rename installationName to customizationClassName
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📢 PSA An announcement about upcoming changes
Projects
None yet
Development

No branches or pull requests

3 participants