fix(node): webpack executor doesn't respect option outputFileName (#9740

) Co-authored-by: zhaoyunfeng <zhaoyunfeng@worktile.com>
nrwl · Apr 8, 2022 · 0e68c61 · 0e68c61
1 parent 5b105b1
commit 0e68c61
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/packages/node/src/executors/webpack/webpack.impl.spec.ts b/packages/node/src/executors/webpack/webpack.impl.spec.ts
@@ -72,6 +72,9 @@ describe('Node Build Executor', () => {
 
     expect(runWebpack).toHaveBeenCalledWith(
       expect.objectContaining({
+        entry: expect.objectContaining({
+          index: ['/root/apps/wibble/src/main.ts'],
+        }),
         output: expect.objectContaining({
           filename: 'index.js',
           libraryTarget: 'commonjs',

diff --git a/packages/node/src/utils/config.ts b/packages/node/src/utils/config.ts
@@ -8,6 +8,7 @@ import { loadTsTransformers } from './load-ts-transformers';
 import { BuildBuilderOptions } from './types';
 import CopyWebpackPlugin = require('copy-webpack-plugin');
 import ForkTsCheckerWebpackPlugin = require('fork-ts-checker-webpack-plugin');
+import { removeExt } from '@nrwl/workspace/src/utils/runtime-lint-utils';
 
 export const OUT_FILENAME_TEMPLATE = '[name].js';
 
@@ -33,9 +34,12 @@ export function getBaseWebpackPartial(
       }),
       {} as { [entryName: string]: string }
     ) ?? {};
+  const mainEntry = options.outputFileName
+    ? removeExt(options.outputFileName)
+    : 'main';
   const webpackConfig: Configuration = {
     entry: {
-      main: [options.main],
+      [mainEntry]: [options.main],
       ...additionalEntryPoints,
     },
     devtool: options.sourceMap ? 'source-map' : false,

diff --git a/packages/workspace/src/utils/runtime-lint-utils.ts b/packages/workspace/src/utils/runtime-lint-utils.ts
@@ -76,7 +76,7 @@ function hasTag(proj: ProjectGraphProjectNode, tag: string) {
   return tag === '*' || (proj.data.tags || []).indexOf(tag) > -1;
 }
 
-function removeExt(file: string): string {
+export function removeExt(file: string): string {
   return file.replace(/(?<!(^|\/))\.[^/.]+$/, '');
 }