Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
fix(web): file-server withDeps is deprecated (#9170)
* fix(web): file-server withDeps is deprecated

* docs(web): fix spacing issue
  • Loading branch information
Coly010 committed Mar 9, 2022
1 parent 88204a0 commit 1440f83
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
6 changes: 4 additions & 2 deletions docs/generated/api-web/executors/file-server.md
Expand Up @@ -73,10 +73,12 @@ Type: `string`

SSL key to use for serving HTTPS.

### withDeps
### ~~withDeps~~

Default: `true`
Default: `false`

Type: `boolean`

**Deprecated:** "withDeps" is deprecated and it will be removed in v14. Configure target dependencies instead: https://nx.dev/configuration/projectjson.

Build the target and all its deps
2 changes: 1 addition & 1 deletion packages/web/src/executors/file-server/file-server.impl.ts
@@ -1,5 +1,5 @@
import { exec, execSync } from 'child_process';
import { ExecutorContext, joinPathFragments } from '@nrwl/devkit';
import { ExecutorContext, joinPathFragments, logger } from '@nrwl/devkit';
import ignore from 'ignore';
import { readFileSync } from 'fs';
import { Schema } from './schema';
Expand Down
3 changes: 2 additions & 1 deletion packages/web/src/executors/file-server/schema.json
Expand Up @@ -11,7 +11,8 @@
"withDeps": {
"type": "boolean",
"description": "Build the target and all its deps",
"default": true
"default": false,
"x-deprecated": "\"withDeps\" is deprecated and it will be removed in v14. Configure target dependencies instead: https://nx.dev/configuration/projectjson."
},
"parallel": {
"type": "boolean",
Expand Down

1 comment on commit 1440f83

@vercel
Copy link

@vercel vercel bot commented on 1440f83 Mar 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.