From 189c03662023ae1a0647c15f8990262c32228a9a Mon Sep 17 00:00:00 2001 From: Katerina Skroumpelou Date: Fri, 3 Jun 2022 13:29:10 +0300 Subject: [PATCH] fix(storybook): ignore addon-notes from version update (#10568) ISSUES CLOSED: #10484 --- .../migrate-defaults-5-to-6.spec.ts | 7 +++++-- .../migrate-defaults-5-to-6/migrate-defaults-5-to-6.ts | 1 + 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/storybook/src/migrations/update-14-0-0/migrate-defaults-5-to-6/migrate-defaults-5-to-6.spec.ts b/packages/storybook/src/migrations/update-14-0-0/migrate-defaults-5-to-6/migrate-defaults-5-to-6.spec.ts index b57b282966f7f..cf3fdc7cfb036 100644 --- a/packages/storybook/src/migrations/update-14-0-0/migrate-defaults-5-to-6/migrate-defaults-5-to-6.spec.ts +++ b/packages/storybook/src/migrations/update-14-0-0/migrate-defaults-5-to-6/migrate-defaults-5-to-6.spec.ts @@ -22,6 +22,7 @@ describe('migrate-defaults-5-to-6 Generator', () => { '@nrwl/workspace': '10.4.0', '@storybook/addon-knobs': '^5.3.8', '@storybook/angular': '^5.3.8', + '@storybook/addon-notes': '5.3.21', }, }; }); @@ -60,17 +61,19 @@ describe('migrate-defaults-5-to-6 Generator', () => { }); }); - it('should update Storybook packages to latest version', async () => { + it('should update Storybook packages to latest version and ignore the ones to be ignored', async () => { migrateDefaultsGenerator(appTree); const packageJson = readJson(appTree, 'package.json'); - // general deps expect(packageJson.devDependencies['@storybook/angular']).toEqual( storybookVersion ); expect(packageJson.devDependencies['@storybook/addon-knobs']).toEqual( storybookVersion ); + expect(packageJson.devDependencies['@storybook/addon-notes']).toEqual( + '5.3.21' + ); }); it('should update root config to version 6', async () => { diff --git a/packages/storybook/src/migrations/update-14-0-0/migrate-defaults-5-to-6/migrate-defaults-5-to-6.ts b/packages/storybook/src/migrations/update-14-0-0/migrate-defaults-5-to-6/migrate-defaults-5-to-6.ts index 550bce4d43ae9..96739e22ac666 100644 --- a/packages/storybook/src/migrations/update-14-0-0/migrate-defaults-5-to-6/migrate-defaults-5-to-6.ts +++ b/packages/storybook/src/migrations/update-14-0-0/migrate-defaults-5-to-6/migrate-defaults-5-to-6.ts @@ -85,6 +85,7 @@ function maybeUpdateVersion(tree: Tree): GeneratorCallback { '@storybook/testing-react', '@storybook/testing-vue', '@storybook/testing-vue3', + '@storybook/addon-notes', ]; json.dependencies = json.dependencies || {};