From 36245e14af6cc660cae5b073ffe118558729c9d5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miroslav=20Jona=C5=A1?= Date: Mon, 21 Feb 2022 17:11:20 +0100 Subject: [PATCH] chore(repo): remove obsolete NX_E2E_SKIP_DAEMON_CLEANUP flag (#9061) --- .github/workflows/e2e-matrix.yml | 1 - .github/workflows/e2e-windows.yml | 1 - e2e/utils/index.ts | 4 ---- 3 files changed, 6 deletions(-) diff --git a/.github/workflows/e2e-matrix.yml b/.github/workflows/e2e-matrix.yml index 26c5687041d98..c59fc191ee217 100644 --- a/.github/workflows/e2e-matrix.yml +++ b/.github/workflows/e2e-matrix.yml @@ -159,7 +159,6 @@ jobs: YARN_REGISTRY: http://localhost:4872 NX_VERBOSE_LOGGING: ${{ 'true' }} NX_E2E_SKIP_BUILD_CLEANUP: ${{ 'true' }} - NX_E2E_SKIP_DAEMON_CLEANUP: ${{ 'true' }} NX_CACHE_DIRECTORY: ${{ matrix.os-cache-dir }} - name: Setup tmate session diff --git a/.github/workflows/e2e-windows.yml b/.github/workflows/e2e-windows.yml index 2f021bbe83156..ab9d6f7773373 100644 --- a/.github/workflows/e2e-windows.yml +++ b/.github/workflows/e2e-windows.yml @@ -77,7 +77,6 @@ jobs: YARN_REGISTRY: http://localhost:4872 NX_VERBOSE_LOGGING: ${{ 'true' }} NX_E2E_SKIP_BUILD_CLEANUP: ${{ 'true' }} - NX_E2E_SKIP_DAEMON_CLEANUP: ${{ 'true' }} NX_CACHE_DIRECTORY: ./nx-cache - name: Setup tmate session diff --git a/e2e/utils/index.ts b/e2e/utils/index.ts index bc60cdd1d323d..b69e4cbbacdcb 100644 --- a/e2e/utils/index.ts +++ b/e2e/utils/index.ts @@ -302,10 +302,6 @@ export async function killPorts(port?: number): Promise { // Useful in order to cleanup space during CI to prevent `No space left on device` exceptions export async function cleanupProject() { if (isCI) { - // Stopping the daemon is not required for tests to pass, but it cleans up background processes - if (process.env.NX_E2E_SKIP_DAEMON_CLEANUP !== 'true') { - runCLI('reset'); - } try { removeSync(tmpProjPath()); } catch (e) {}