feat(core): memoize project source hashing

Author: vsavkin

packages/workspace/src/tasks-runner/hasher.ts

@@ -53,29 +53,41 @@ export class Hasher {
 }
 
 export class ProjectHashes {
+  private sourceHashes: { [projectName: string]: Promise<string> } = {};
+
   constructor(
     private readonly projectGraph: ProjectGraph,
     private readonly fileHashes: FileHashes
   ) {}
 
   async hashProject(projectName: string, visited: string[]) {
     return Promise.resolve().then(async () => {
-      const deps = (this.projectGraph.dependencies[projectName] || []).map(t =>
-        visited.indexOf(t.target) > -1
-          ? ''
-          : this.hashProject(t.target, [t.target, ...visited])
+      const deps = (this.projectGraph.dependencies[projectName] || []).map(
+        t => {
+          if (visited.indexOf(t.target) > -1) {
+            return '';
+          } else {
+            visited.push(t.target);
+            return this.hashProject(t.target, visited);
+          }
+        }
       );
       const sources = this.hashProjectNodeSource(projectName);
       return hasha(await Promise.all([...deps, sources]));
     });
   }
 
   private async hashProjectNodeSource(projectName: string) {
-    const p = this.projectGraph.nodes[projectName];
-    const values = await Promise.all(
-      p.data.files.map(f => this.fileHashes.hashFile(f.file))
-    );
-    return hasha(values, { algorithm: 'sha256' });
+    if (!this.sourceHashes[projectName]) {
+      this.sourceHashes[projectName] = new Promise(async res => {
+        const p = this.projectGraph.nodes[projectName];
+        const values = await Promise.all(
+          p.data.files.map(f => this.fileHashes.hashFile(f.file))
+        );
+        res(hasha(values, { algorithm: 'sha256' }));
+      });
+    }
+    return this.sourceHashes[projectName];
   }
 }
 

scripts/e2e-ci2.sh

@@ -6,8 +6,6 @@ rm -rf tmp
 mkdir -p tmp/angular
 mkdir -p tmp/nx
 
-# Please keep this in alphabetical order
-# This should be every file under e2e except for utils.js after ng-add.test.ts
 export SELECTED_CLI=$1
 jest --maxWorkers=1 ./build/e2e/ng-add.test.js &&
 jest --maxWorkers=1 ./build/e2e/ngrx.test.js &&

scripts/e2e-ci3.sh

@@ -0,0 +1,17 @@
+#!/usr/bin/env bash
+
+./scripts/link.sh
+
+rm -rf tmp
+mkdir -p tmp/angular
+mkdir -p tmp/nx
+
+export SELECTED_CLI=$1
+jest --maxWorkers=1 ./build/e2e/run-many.test.js &&
+jest --maxWorkers=1 ./build/e2e/storybook.test.js &&
+jest --maxWorkers=1 ./build/e2e/upgrade-module.test.js &&
+jest --maxWorkers=1 ./build/e2e/web.test.js &&
+jest --maxWorkers=1 ./build/e2e/tasks-runner-v2.test.js &&
+jest --maxWorkers=1 ./build/e2e/angular-package.test.js &&
+jest --maxWorkers=1 ./build/e2e/react-package.test.js &&
+jest --maxWorkers=1 ./build/e2e/ngrx.test.js

scripts/e2e-ci4.sh

@@ -0,0 +1,15 @@
+#!/usr/bin/env bash
+
+./scripts/link.sh
+
+rm -rf tmp
+mkdir -p tmp/angular
+mkdir -p tmp/nx
+
+export SELECTED_CLI=$1
+jest --maxWorkers=1 ./build/e2e/ng-add.test.js &&
+jest --maxWorkers=1 ./build/e2e/node.test.js &&
+jest --maxWorkers=1 ./build/e2e/nx-plugin.test.js &&
+jest --maxWorkers=1 ./build/e2e/print-affected.test.js &&
+jest --maxWorkers=1 ./build/e2e/react.test.js &&
+jest --maxWorkers=1 ./build/e2e/report.test.js