Skip to content

Commit

Permalink
fix(angular): renable v1 lib test (#9494)
Browse files Browse the repository at this point in the history
  • Loading branch information
Coly010 committed Mar 24, 2022
1 parent 1903f01 commit 6b6f192
Showing 1 changed file with 24 additions and 23 deletions.
47 changes: 24 additions & 23 deletions packages/angular/src/generators/library/library.spec.ts
Expand Up @@ -9,6 +9,7 @@ import {
} from '@nrwl/devkit';
import { createTreeWithEmptyWorkspace } from '@nrwl/devkit/testing';
import { Linter } from '@nrwl/linter';
import { toNewFormat } from 'nx/src/shared/workspace';
import { createApp } from '../../utils/nx-devkit/testing';
import { UnitTestRunner } from '../../utils/test-runners';
import {
Expand Down Expand Up @@ -75,29 +76,29 @@ describe('lib', () => {
});
});

// describe('workspace v1', () => {
// beforeEach(() => {
// tree = createTreeWithEmptyWorkspace(1);
// });
//
// it('should default to inline project for first project', async () => {
// await runLibraryGeneratorWithOpts({
// standaloneConfig: false,
// });
// const workspaceJsonEntry = toNewFormat(readJson(tree, 'workspace.json'))
// .projects['my-lib'];
// const projectConfig = readProjectConfiguration(tree, 'my-lib');
// expect(projectConfig.root).toEqual('libs/my-lib');
// expect(projectConfig).toMatchObject(workspaceJsonEntry);
// });
//
// it('should throw for standaloneConfig === true', async () => {
// const promise = runLibraryGeneratorWithOpts({
// standaloneConfig: true,
// });
// await expect(promise).rejects.toThrow();
// });
// });
describe('workspace v1', () => {
beforeEach(() => {
tree = createTreeWithEmptyWorkspace(1);
});

it('should default to inline project for first project', async () => {
await runLibraryGeneratorWithOpts({
standaloneConfig: false,
});
const workspaceJsonEntry = toNewFormat(readJson(tree, 'workspace.json'))
.projects['my-lib'];
const projectConfig = readProjectConfiguration(tree, 'my-lib');
expect(projectConfig.root).toEqual('libs/my-lib');
expect(projectConfig).toMatchObject(workspaceJsonEntry);
});

it('should throw for standaloneConfig === true', async () => {
const promise = runLibraryGeneratorWithOpts({
standaloneConfig: true,
});
await expect(promise).rejects.toThrow();
});
});

describe('not nested', () => {
it('should update ng-package.json', async () => {
Expand Down

0 comments on commit 6b6f192

Please sign in to comment.