fix(core): preset core should remove workspace.json (#9710)

nrwl · Apr 6, 2022 · 704b6c8 · 704b6c8
1 parent 1fc0606
commit 704b6c8
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/packages/workspace/src/generators/preset/preset.spec.ts b/packages/workspace/src/generators/preset/preset.spec.ts
@@ -167,6 +167,19 @@ describe('preset', () => {
   });
 
   describe('core preset', () => {
+    it('should not contain workspace.json or angular.json', async () => {
+      await presetGenerator(tree, {
+        name: 'proj',
+        preset: Preset.Core,
+        linter: 'eslint',
+        cli: 'nx',
+        standaloneConfig: false,
+        packageManager: 'npm',
+      });
+      expect(tree.exists('workspace.json')).toBeFalsy();
+      expect(tree.exists('angular.json')).toBeFalsy();
+    });
+
     describe('package manager workspaces', () => {
       it('should be configured in package.json', async () => {
         await presetGenerator(tree, {

diff --git a/packages/workspace/src/generators/preset/preset.ts b/packages/workspace/src/generators/preset/preset.ts
@@ -184,6 +184,9 @@ async function createPreset(tree: Tree, options: Schema) {
     setDefaultCollection(tree, '@nrwl/react-native');
   } else if (options.preset === Preset.Core || options.preset === Preset.NPM) {
     setupPackageManagerWorkspaces(tree, options);
+    if (options.preset === Preset.Core) {
+      tree.delete('workspace.json');
+    }
   } else {
     throw new Error(`Invalid preset ${options.preset}`);
   }