From 704b6c88e02c114c5c65271584ac342d0af588dc Mon Sep 17 00:00:00 2001 From: Craigory Coppola Date: Wed, 6 Apr 2022 11:38:56 -0400 Subject: [PATCH] fix(core): preset core should remove workspace.json (#9710) --- .../workspace/src/generators/preset/preset.spec.ts | 13 +++++++++++++ packages/workspace/src/generators/preset/preset.ts | 3 +++ 2 files changed, 16 insertions(+) diff --git a/packages/workspace/src/generators/preset/preset.spec.ts b/packages/workspace/src/generators/preset/preset.spec.ts index 63598a3df6925..5163ef862c98d 100644 --- a/packages/workspace/src/generators/preset/preset.spec.ts +++ b/packages/workspace/src/generators/preset/preset.spec.ts @@ -167,6 +167,19 @@ describe('preset', () => { }); describe('core preset', () => { + it('should not contain workspace.json or angular.json', async () => { + await presetGenerator(tree, { + name: 'proj', + preset: Preset.Core, + linter: 'eslint', + cli: 'nx', + standaloneConfig: false, + packageManager: 'npm', + }); + expect(tree.exists('workspace.json')).toBeFalsy(); + expect(tree.exists('angular.json')).toBeFalsy(); + }); + describe('package manager workspaces', () => { it('should be configured in package.json', async () => { await presetGenerator(tree, { diff --git a/packages/workspace/src/generators/preset/preset.ts b/packages/workspace/src/generators/preset/preset.ts index 2dcadf61c2ad3..391d2924a63e7 100644 --- a/packages/workspace/src/generators/preset/preset.ts +++ b/packages/workspace/src/generators/preset/preset.ts @@ -184,6 +184,9 @@ async function createPreset(tree: Tree, options: Schema) { setDefaultCollection(tree, '@nrwl/react-native'); } else if (options.preset === Preset.Core || options.preset === Preset.NPM) { setupPackageManagerWorkspaces(tree, options); + if (options.preset === Preset.Core) { + tree.delete('workspace.json'); + } } else { throw new Error(`Invalid preset ${options.preset}`); }