From 8010270377d683f9865e514319328b6d4c893758 Mon Sep 17 00:00:00 2001
From: Nadav Shatz <nadav@tailorbrands.com>
Date: Mon, 21 Aug 2023 16:48:25 +0300
Subject: [PATCH] fix(react): fix remote generation devServerPort (#18603)

(cherry picked from commit 1a0962fcaf61d7061c24bebeb6a78bfccc369ade)
---
 docs/generated/packages/react/generators/remote.json | 1 -
 e2e/react-core/src/react-module-federation.test.ts   | 5 +++++
 packages/react/src/generators/remote/schema.json     | 1 -
 3 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/docs/generated/packages/react/generators/remote.json b/docs/generated/packages/react/generators/remote.json
index ae32c075dc096..c0ea5bfe98da4 100644
--- a/docs/generated/packages/react/generators/remote.json
+++ b/docs/generated/packages/react/generators/remote.json
@@ -147,7 +147,6 @@
       "devServerPort": {
         "type": "number",
         "description": "The port for the dev server of the remote app.",
-        "default": 4200,
         "x-priority": "important"
       },
       "ssr": {
diff --git a/e2e/react-core/src/react-module-federation.test.ts b/e2e/react-core/src/react-module-federation.test.ts
index 329bc3356588a..ad3dd831213a7 100644
--- a/e2e/react-core/src/react-module-federation.test.ts
+++ b/e2e/react-core/src/react-module-federation.test.ts
@@ -44,6 +44,11 @@ describe('React Module Federation', () => {
       combinedOutput: expect.stringContaining('Test Suites: 1 passed, 1 total'),
     });
 
+    expect(readPort(shell)).toEqual(4200);
+    expect(readPort(remote1)).toEqual(4201);
+    expect(readPort(remote2)).toEqual(4202);
+    expect(readPort(remote3)).toEqual(4203);
+
     updateFile(
       `apps/${shell}/webpack.config.js`,
       stripIndents`
diff --git a/packages/react/src/generators/remote/schema.json b/packages/react/src/generators/remote/schema.json
index bac051c186434..a9fae49b73532 100644
--- a/packages/react/src/generators/remote/schema.json
+++ b/packages/react/src/generators/remote/schema.json
@@ -153,7 +153,6 @@
     "devServerPort": {
       "type": "number",
       "description": "The port for the dev server of the remote app.",
-      "default": 4200,
       "x-priority": "important"
     },
     "ssr": {